pygame is sharing code with you

Bitbucket is a code hosting site. Unlimited public and private repositories. Free for small teams.

Don't show this again

pygame / pygame http://pygame.org/

Clone this repository (size: 15.4 MB): HTTPS / SSH
hg clone https://bitbucket.org/pygame/pygame
hg clone ssh://hg@bitbucket.org/pygame/pygame

Issues

#94 src/scale_mmx64.c cannot be compiled with clang

Reported by Joshua Root

Building pygame on OS X 10.7.2 with Xcode 4.2 and a python compiled with clang fails like this:

src/scale_mmx64.c:424:27: error: invalid instruction mnemonic 'movsxl'

I'm not an x86_64 asm expert, but I think the attached patch should be correct.

Status: open Responsible: illume Type: bug Priority: major
Milestone: none Component: none Version: none

Attachments

Comments and changes

  1. #1 Joshua Root

    written

    • Changed title from src/scale_mmx64.c canot be compiled with clang to src/scale_mmx64.c cannot be compiled with clang.
  2. #2 illume

    written

    • Changed responsible from nobody to illume.
    • Changed status from new to open.

    Thanks Joshua. Added it to my list of issues/patches to review.

    cheers,

  3. #3 Lenard Lindstrom

    written

    • Changed status from open to new.

    The patch looks good. MOVSLQ is the AT&T assembler instruction to move a 32 bit value into a 64 bit register with sign extension, which is what we want. Why the 32 bit RAX register is used instead of 32 bit EAX is a mystery to me thought.

  4. #4 Lenard Lindstrom

    written

    • Changed status from new to open.
  5. #5 Anonymous

    written

    This solved my issue while building pygame on Lion. Thank you!

Add comment / attachment

Verification: Please write the text from the image in the box (letters only)

captcha

Is that you, Humanoid? Is this me?